[noosfero/noosfero][next] Fix inclusion of javascript files from plugins

[Victor Costa]

Victor Costa pushed to branch next at Noosfero / noosfero


Commits:
356ed1a3 by Victor Costa at 2015-04-27T17:57:35Z
Fix inclusion of javascript files from plugins

- - - - -


2 changed files:

- app/helpers/layout_helper.rb
- test/unit/layout_helper_test.rb


Changes:

=====================================
app/helpers/layout_helper.rb
=====================================
--- a/app/helpers/layout_helper.rb
+++ b/app/helpers/layout_helper.rb
@@ -28,7 +28,7 @@ module LayoutHelper
   end
 
   def noosfero_javascript
-    plugins_javascripts = @plugins.flat_map{ |plugin| plugin.js_files.map{ |js| plugin.class.public_path(js, true) } }.flatten
+    plugins_javascripts = @plugins.flat_map{ |plugin| Array.wrap(plugin.js_files).map{ |js| plugin.class.public_path(js, true) } }.flatten
 
     output = ''
     output += render 'layouts/javascript'


=====================================
test/unit/layout_helper_test.rb
=====================================
--- a/test/unit/layout_helper_test.rb
+++ b/test/unit/layout_helper_test.rb
@@ -30,4 +30,17 @@ class LayoutHelperTest < ActionView::TestCase
     assert_match /<link [^<]*href="\/designs\/themes\/my-theme\/global.css"/, css
   end
 
+  should 'append javascript files of enabled plugins in noosfero javascripts' do
+    plugin1 = Noosfero::Plugin.new
+    plugin1.expects(:js_files).returns(['plugin1.js'])
+    plugin2 = Noosfero::Plugin.new
+    plugin2.expects(:js_files).returns('plugin2.js')
+    @plugins = [plugin1, plugin2]
+    expects(:environment).returns(Environment.default).at_least_once
+    expects(:profile).returns(nil).at_least_once
+    js_tag = noosfero_javascript
+    assert_match /plugin1\.js/, js_tag
+    assert_match /plugin2\.js/, js_tag
+  end
+
 end



View it on GitLab: https://gitlab.com/noosfero/noosfero/commit/356ed1a35203e1fabc2e1762759c28090de75c15
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20150427/e93aded0/attachment.html>