[Git][noosfero/noosfero][master] A saner implementation for assert_equivalent

[Antonio Terceiro]

Antonio Terceiro pushed to branch master at Noosfero / noosfero


Commits:
fd438e0d by Antonio Terceiro at 2015-12-11T11:46:48Z
A saner implementation for assert_equivalent

Using the predefined assertion methods will give us meaningful failure
messages by default.

- - - - -


1 changed file:

- test/test_helper.rb


Changes:

=====================================
test/test_helper.rb
=====================================
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -87,9 +87,11 @@ class ActiveSupport::TestCase
   alias :ok :assert_block
 
   def assert_equivalent(enum1, enum2)
-    enum1 = enum1.group_by{|e|e}.values
-    enum2 = enum2.group_by{|e|e}.values
-    assert( (enum1.length == enum2.length) && ((enum1 - enum2) == []), "<#{enum1.inspect}> expected to be equivalent to <#{enum2.inspect}>")
+    norm1 = enum1.to_a
+    norm2 = enum2.to_a
+    assert_equal [], norm1 - norm2
+    assert_equal [], norm2 - norm1
+    assert_equal norm1.size, enum2.size, "Size mismatch: #{enum1.inspect} vs #{enum2.inspect}"
   end
 
   def assert_mandatory(object, attribute, test_value = 'some random string')



View it on GitLab: https://gitlab.com/noosfero/noosfero/commit/fd438e0dc3fec1fea96e733b9b435a9e165d48da
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20151211/84a34ad8/attachment-0001.html>