Unit test failing again

Tue Jun 9 20:11:10 BRT 2015

We have been having this kind of problem for a long time. Both the sender
and  who incorporates the MR have responsibility for it. However, there are
many causes that breaks the tests

l.E: If Feature A is incorporated before the feature B, when B is merged
into master, maybe its feature or tests break because of the code related
to Feature A.

Anyway, we from SPB team are trying to all of them. We've just made this
new MR that solves most of broken tests ->
https://gitlab.com/noosfero/noosfero/merge_requests/597

Still there are some tests that we still couldn't fix, mainly related to
the "vote" feature incorporeted into the core recently =) (
https://gitlab.com/noosfero/noosfero/merge_requests/589)

Let's work together to "stabilize" the master again.

2015-06-09 19:34 GMT-03:00 Leandro Nunes <leandronunes at gmail.com>:

> Hi Braulio,
>
> Just to avoid any misunderstanding.
> It's not a critique for you specifically.
> My email was just to make everyone to pay attention in the tests before
> incoporate anything in the master branch.
>
> Here in my organization we have a lot of work to avoid make a fork in
> Noosfero. Look how many branches we have (
> https://gitlab.com/participa/noosfero/branches) and we just make this
> because we have a strong quality control of the code.
> I could affirm for you that none of the failing tests in the last year was
> caused by us, because we always run all of the tests before submit anything
> to core.
> Of course we introduced some bugs in Noosfero, but for sure the tests are
> passing. At least in our environment. :)
>
> For now we are training ate least 3 people to transform them in core team
> in the future, but how we can maitain the discourse of quality if the
> community it's not worried with this?
> New developers could not make a secure modification with tests failing.
> Of course anyone could make mistakes, but lately it's comom to have
> falling tests in Noosfero code.
> I repeat. It's not just for you man. It's for all core team.
> I just mentioned you in this case beacuse you have more experience with
> enterprises stuff. So is more easy for you to fix the problem.
> Pay attention that could be a problem caused by us, but I asked for your
> help. ;)
>
> So, everybody please pay attetion at least for the unit and functional
> tests.
>
>
> 2015-06-09 15:57 GMT-03:00 Bráulio Bhavamitra <braulio at eita.org.br>:
>
>> Leandro, so these tests seem to have been fixed by diguliu.
>>
>> I'm also waiting for tests to get into a passing state so that we keep
>> merging new stuff with confidence we are not breaking stuff.
>>
>> Still there is no CI solution for MRs, Tallys will try something using
>> web hooks.
>>
>> cheers,
>> bráulio
>>
>> On Sat, May 30, 2015 at 10:04 PM, Leandro Nunes <leandronunes at gmail.com>
>> wrote:
>>
>>> :(
>>>
>>> Finished tests in 352.180950s, 8.9187 tests/s, 16.7556 assertions/s.
>>>
>>>   1) Failure:
>>> test_should_be_created_disabled_if_feature_enterprises_are_disabled_when_created_is_enabled(EnterpriseTest)
>>> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:359]:
>>> <false> expected but was
>>> <true>.
>>>
>>>   2) Failure:
>>> test_should_have_inactive_template_even_when_there_is_a_template_set(EnterpriseTest)
>>> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:277]:
>>> <Enterprise/64/inactive_enterprise_template> expected but was
>>> <Enterprise/63/enterprise-3560>.
>>>
>>>   3) Failure:
>>> test_should_have_inactive_template_when_creating_enterprise_and_feature_is_enabled(EnterpriseTest)
>>> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:388]:
>>> <1> expected but was
>>> <4>.
>>>
>>>   4) Failure:
>>> test_should_not_replace_template_if_environment_doesnt_allow(EnterpriseTest)
>>> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:203]:
>>> <1> expected but was
>>> <4>.
>>>
>>> --
>>> Dois Axé!!!
>>>
>>> -----
>>> "Comece fazendo o que é necessário, depois o que é possível e de repente
>>> você estará fazendo o impossível."
>>>                                    São Francisco de Assis
>>> Leandro Nunes
>>>
>>> _______________________________________________
>>> Noosfero-dev mailing list
>>> Noosfero-dev at listas.softwarelivre.org
>>> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>>>
>>>
>>
>>
>> --
>> "Lute pela sua ideologia. Seja um com sua ideologia. Viva pela sua
>> ideologia. Morra por sua ideologia" P.R. Sarkar
>>
>> EITA - Educação, Informação e Tecnologias para Autogestão
>> http://cirandas.net/brauliobo
>> http://eita.org.br
>>
>> "Paramapurusha é meu pai e Parama Prakriti é minha mãe. O universo é meu
>> lar e todos nós somos cidadãos deste cosmo. Este universo é a imaginação da
>> Mente Macrocósmica, e todas as entidades estão sendo criadas, preservadas e
>> destruídas nas fases de extroversão e introversão do fluxo imaginativo
>> cósmico. No âmbito pessoal, quando uma pessoa imagina algo em sua mente,
>> naquele momento, essa pessoa é a única proprietária daquilo que ela
>> imagina, e ninguém mais. Quando um ser humano criado mentalmente caminha
>> por um milharal também imaginado, a pessoa imaginada não é a propriedade
>> desse milharal, pois ele pertence ao indivíduo que o está imaginando. Este
>> universo foi criado na imaginação de Brahma, a Entidade Suprema, por isso
>> a propriedade deste universo é de Brahma, e não dos microcosmos que também
>> foram criados pela imaginação de Brahma. Nenhuma propriedade deste mundo,
>> mutável ou imutável, pertence a um indivíduo em particular; tudo é o
>> patrimônio comum de todos."
>> Restante do texto em
>> http://cirandas.net/brauliobo/blog/a-problematica-de-hoje-em-dia
>>
>> _______________________________________________
>> Noosfero-dev mailing list
>> Noosfero-dev at listas.softwarelivre.org
>> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>>
>>
>
>
> --
> Dois Axé!!!
>
> -----
> "Comece fazendo o que é necessário, depois o que é possível e de repente
> você estará fazendo o impossível."
>                                    São Francisco de Assis
> Leandro Nunes
>
> _______________________________________________
> Noosfero-dev mailing list
> Noosfero-dev at listas.softwarelivre.org
> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>
>

-- 
*Arthur de Moura Del Esposte*
Engenheiro de Software

Colivre - http://colivre.coop.br/
LAPPIS - http://fga.unb.br/lappis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20150609/8d6a4d80/attachment-0001.html>