Unit test failing again

Rodrigo Souto rodrigo at colivre.coop.br
Thu Jun 11 15:14:04 BRT 2015 

This is (will always be) a never-ending problem until we have the proper
CI configured for the master branch and for MRs. I'm pretty sure every
organization already broke noosfero tests (including Serpro) and this
happens because running all noosfero tests is a pain in the ass,
specially if we are talking about cucumber/selenium tests, and because
the master branch is a common branch with constant code changes, it'll
break eventually. That's what freezes are for.

I agree that we should be more worried about not breaking tests, but as
you mentioned, not breaking tests doesn't mean everything is working.
And sometimes broken tests are just poorly written tests, not broken
features.

Things will break. We should worry about breaking them but, more
importantly, we must worry about fixing them.

Leandro Nunes escreveu isso ai:
> Hi Braulio,
> 
> Just to avoid any misunderstanding.
> It's not a critique for you specifically.
> My email was just to make everyone to pay attention in the tests before
> incoporate anything in the master branch.
> 
> Here in my organization we have a lot of work to avoid make a fork in
> Noosfero. Look how many branches we have (
> https://gitlab.com/participa/noosfero/branches) and we just make this
> because we have a strong quality control of the code.
> I could affirm for you that none of the failing tests in the last year was
> caused by us, because we always run all of the tests before submit anything
> to core.
> Of course we introduced some bugs in Noosfero, but for sure the tests are
> passing. At least in our environment. :)
> 
> For now we are training ate least 3 people to transform them in core team
> in the future, but how we can maitain the discourse of quality if the
> community it's not worried with this?
> New developers could not make a secure modification with tests failing.
> Of course anyone could make mistakes, but lately it's comom to have falling
> tests in Noosfero code.
> I repeat. It's not just for you man. It's for all core team.
> I just mentioned you in this case beacuse you have more experience with
> enterprises stuff. So is more easy for you to fix the problem.
> Pay attention that could be a problem caused by us, but I asked for your
> help. ;)
> 
> So, everybody please pay attetion at least for the unit and functional
> tests.
> 
> 
> 2015-06-09 15:57 GMT-03:00 Bráulio Bhavamitra <braulio at eita.org.br>:
> 
> > Leandro, so these tests seem to have been fixed by diguliu.
> >
> > I'm also waiting for tests to get into a passing state so that we keep
> > merging new stuff with confidence we are not breaking stuff.
> >
> > Still there is no CI solution for MRs, Tallys will try something using web
> > hooks.
> >
> > cheers,
> > bráulio
> >
> > On Sat, May 30, 2015 at 10:04 PM, Leandro Nunes <leandronunes at gmail.com>
> > wrote:
> >
> >> :(
> >>
> >> Finished tests in 352.180950s, 8.9187 tests/s, 16.7556 assertions/s.
> >>
> >>   1) Failure:
> >> test_should_be_created_disabled_if_feature_enterprises_are_disabled_when_created_is_enabled(EnterpriseTest)
> >> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:359]:
> >> <false> expected but was
> >> <true>.
> >>
> >>   2) Failure:
> >> test_should_have_inactive_template_even_when_there_is_a_template_set(EnterpriseTest)
> >> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:277]:
> >> <Enterprise/64/inactive_enterprise_template> expected but was
> >> <Enterprise/63/enterprise-3560>.
> >>
> >>   3) Failure:
> >> test_should_have_inactive_template_when_creating_enterprise_and_feature_is_enabled(EnterpriseTest)
> >> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:388]:
> >> <1> expected but was
> >> <4>.
> >>
> >>   4) Failure:
> >> test_should_not_replace_template_if_environment_doesnt_allow(EnterpriseTest)
> >> [/home/leandronunes/projetos/noosfero/test/unit/enterprise_test.rb:203]:
> >> <1> expected but was
> >> <4>.
> >>
> >> --
> >> Dois Axé!!!
> >>
> >> -----
> >> "Comece fazendo o que é necessário, depois o que é possível e de repente
> >> você estará fazendo o impossível."
> >>                                    São Francisco de Assis
> >> Leandro Nunes
> >>
> >> _______________________________________________
> >> Noosfero-dev mailing list
> >> Noosfero-dev at listas.softwarelivre.org
> >> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
> >>
> >>
> >
> >
> > --
> > "Lute pela sua ideologia. Seja um com sua ideologia. Viva pela sua
> > ideologia. Morra por sua ideologia" P.R. Sarkar
> >
> > EITA - Educação, Informação e Tecnologias para Autogestão
> > http://cirandas.net/brauliobo
> > http://eita.org.br
> >
> > "Paramapurusha é meu pai e Parama Prakriti é minha mãe. O universo é meu
> > lar e todos nós somos cidadãos deste cosmo. Este universo é a imaginação da
> > Mente Macrocósmica, e todas as entidades estão sendo criadas, preservadas e
> > destruídas nas fases de extroversão e introversão do fluxo imaginativo
> > cósmico. No âmbito pessoal, quando uma pessoa imagina algo em sua mente,
> > naquele momento, essa pessoa é a única proprietária daquilo que ela
> > imagina, e ninguém mais. Quando um ser humano criado mentalmente caminha
> > por um milharal também imaginado, a pessoa imaginada não é a propriedade
> > desse milharal, pois ele pertence ao indivíduo que o está imaginando. Este
> > universo foi criado na imaginação de Brahma, a Entidade Suprema, por isso
> > a propriedade deste universo é de Brahma, e não dos microcosmos que também
> > foram criados pela imaginação de Brahma. Nenhuma propriedade deste mundo,
> > mutável ou imutável, pertence a um indivíduo em particular; tudo é o
> > patrimônio comum de todos."
> > Restante do texto em
> > http://cirandas.net/brauliobo/blog/a-problematica-de-hoje-em-dia
> >
> > _______________________________________________
> > Noosfero-dev mailing list
> > Noosfero-dev at listas.softwarelivre.org
> > http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
> >
> >
> 
> 
> -- 
> Dois Axé!!!
> 
> -----
> "Comece fazendo o que é necessário, depois o que é possível e de repente
> você estará fazendo o impossível."
>                                    São Francisco de Assis
> Leandro Nunes

> _______________________________________________
> Noosfero-dev mailing list
> Noosfero-dev at listas.softwarelivre.org
> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev


-- 
Rodrigo Souto <rodrigo at colivre.coop.br> :: 55 71 8131-7714
Colivre - Cooperativa de Tecnologias Livres
http://www.colivre.coop.br/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20150611/1a89ce58/attachment.pgp>

More information about the Noosfero-dev mailing list