[noosfero/noosfero][master] stoa-plugin: Fixes broken tests

Larissa Reis gitlab at gitlab.com
Wed Mar 25 16:38:19 BRT 2015


Larissa Reis pushed to master at Noosfero / noosfero


Commits:
4bf11ff9 by Larissa Reis at 2015-03-25T16:34:04Z
stoa-plugin: Fixes broken tests

- - - - -


3 changed files:

- lib/tasks/plugins_tests.rake
- plugins/stoa/lib/stoa_plugin.rb
- plugins/stoa/test/functional/invite_controller_test.rb


Changes:

=====================================
lib/tasks/plugins_tests.rake
=====================================
--- a/lib/tasks/plugins_tests.rake
+++ b/lib/tasks/plugins_tests.rake
@@ -4,7 +4,6 @@ $broken_plugins = %w[
   comment_classification
   ldap
   solr
-  stoa
 ]
 
 @all_plugins = Dir.glob('plugins/*').map { |f| File.basename(f) } - ['template']

=====================================
plugins/stoa/lib/stoa_plugin.rb
=====================================
--- a/plugins/stoa/lib/stoa_plugin.rb
+++ b/plugins/stoa/lib/stoa_plugin.rb
@@ -60,13 +60,14 @@ class StoaPlugin < Noosfero::Plugin
   end
 
   def account_controller_filters
-    block = lambda do |context|
+    block = proc do
       params[:profile_data] ||= {}
       params[:profile_data][:invitation_code] = params[:invitation_code]
       invitation = Task.pending.find(:first, :conditions => {:code => params[:invitation_code]})
       if request.post?
         if !invitation && !StoaPlugin::UspUser.matches?(params[:profile_data][:usp_id], params[:confirmation_field], params[params[:confirmation_field]])
-          @person = Person.new(:environment => context.environment)
+          # `self` below is evaluated in the context of account_controller
+          @person = Person.new(:environment => self.environment)
           @person.errors.add(:usp_id, _(' validation failed'))
           render :action => :signup
         end

=====================================
plugins/stoa/test/functional/invite_controller_test.rb
=====================================
--- a/plugins/stoa/test/functional/invite_controller_test.rb
+++ b/plugins/stoa/test/functional/invite_controller_test.rb
@@ -57,7 +57,7 @@ class InviteControllerTest < ActionController::TestCase
     organization.add_admin(admin)
 
     login_as(admin.identifier)
-    get :search_friend, :profile => organization.identifier, :q => '1234'
+    get :search, :profile => organization.identifier, :q => '1234'
 
     assert_equal [{"id" => person.id, "name" => person.name}].to_json, @response.body
     assert_response 200


View it on GitLab: https://gitlab.com/noosfero/noosfero/commit/4bf11ff9d7f6cbc79d2bc85216f1000aa6741efd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20150325/3bb29b0b/attachment.html>


More information about the Noosfero-dev mailing list