noosfero | Confgurable Navigation (#575)
Aurélio A. Heckert
gitlab at gitlab.com
Tue May 26 16:33:33 BRT 2015
New comment for Merge Request 575
https://gitlab.com/noosfero/noosfero/merge_requests/575#note_1286353
Aurélio A. Heckert
That is a good thing in most cases, but here will be only more trouble.
The id is configurable (to allow reuse), so we must add a helper class, that will not reduce code so well. But the real problem is to remove two small lines here and add a function on the bloated `application.js` file to run on `pageload`, with more js code than we have here.
All search box logic is placed here, simple and direct. On other hand, we will have a hidden logic set on other file, then future developers will suffer a bit more to discover future problems.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20150526/a3244545/attachment.html>
More information about the Noosfero-dev
mailing list