noosfero | Applying SOLID techniques (!1273)

[antoniocoj]

antoniocoj commented on a discussion on app/models/concerns/code_numbering.rb:

>        self.code_scope.maximum(self.code_numbering_field) || 0
>      end
>  
> +    def code_max

@leandronunes I couldn't find this class tests, could you show me? 
Another question, Is the test really necessary? because the method that I extract the new method is using the new one, so, considering that this old one is already tested, and now it is using the new one and the tests are stil passing, why do I need to test the new one?

---
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1273#note_34190056
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20170704/9925b622/attachment.html>