noosfero | Helper application (!1271)

Rodrigo Souto gitlab at mg.gitlab.com
Thu Jul 6 16:02:27 BRT 2017


This is a nice refactoring but needs some adjustments besides the ones I pointed on the code:

1. Squash your commits into a single commit: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
2. Remove unrelated commits.
3. Make sure the testing pipeline of your request is passing. Sometimes the tests fail randomly and you may need to retry the failed tests a couple times to get them passing. This is a mandatory requirement for me to accept you merge-request.

---
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1271#note_34374148
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20170706/b00f7674/attachment.html>


More information about the Noosfero-dev mailing list