noosfero | Creating plugin to manage system administrator to install themes (!1229)

[Felipe Araujo]

"Hey @lioh, before any review, here are somethings for you to adjust on your merge-request (and for the next ones as well): 1 Remove every change to po files. When you update the po's you basically change every po on Noosfero, which makes your merge-request pretty messy to review. Core translations should be done through weblate. If you want to add the translations of your plugin, add only the plugin's po's. 1 Squash your commits into a single commit unless you are using proper [[micro-commits][http://lucasr.org/2011/01/29/micro-commits/]]. 1 Include a more verbose explanation of what your plugin does and its features. 1 Add some screenshots or videos for us to understand your feature without the need of installing it on a development environment."

@diguliu I ended up closing the previous merge request, sorry. But following your tips above I removed the modifications in the po files and added a more detailed description of the plugin, I hope that the review can now be started :)

---
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1229#note_31426995
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20170602/6bb09ef0/attachment-0001.html>