noosfero | Improvements on upload quota feature (!1321)

Rodrigo Souto gitlab at mg.gitlab.com
Wed Oct 4 08:22:38 BRT 2017


Rodrigo Souto started a new discussion on app/controllers/admin/profile_quotas_controller.rb:

>  class ProfileQuotasController < AdminController
>  
>    def index
> -    asset = params[:asset].in?(type_filters.values) ? params[:asset] : :profiles
> -    scope = environment.send(asset).no_templates.order('name')
> -    @profiles = find_by_contents(asset, environment, scope, params[:q],
> -                                 paginate_options)[:results]
> +    asset = params[:asset].in?(type_filters.values) ? params[:asset]
> +                                                    : :profiles
> +    order = params[:order_by].in?(order_filters.values) ? params[:order_by]
> +                                                        : nil
> +    scope = environment.send(asset).no_templates
> +    results = find_by_contents(asset, environment, scope, params[:q],
> +                               paginate_options, filter: order)[:results]
> +    @profiles = results.order('name')

Isn't this order here messing with the previous order?

---
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1321#note_42370209
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20171004/58dfab68/attachment-0001.html>


More information about the Noosfero-dev mailing list