noosfero | Adds "Filter by Profile Kind" option to ProfileListBlock (!1391)

Rodrigo Souto gitlab at mg.gitlab.com
Thu Feb 1 16:48:21 BRST 2018


Rodrigo Souto commented on a discussion on app/models/profile_list_block.rb:

>    def profile_list
>      result = nil
>      public_profiles = profiles.is_public.includes([:image,:domains,:preferred_domain,:environment])
> +    public_profiles = filter_by_kind(public_profiles) if kind_filter.present?

Actually it looks like it's just unnecessary because you use `find_by` down there, so I think this check here is redundant.

---
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1391#note_57194958
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20180201/f301ab16/attachment.html>


More information about the Noosfero-dev mailing list