noosfero | Refactores application.js (!1564)

Rodrigo Souto gitlab at mg.gitlab.com
Fri Jul 6 09:19:14 BRT 2018


Hi @LucasMartins, this seems allright. I just have 2 points for you to review:
1. The task part was changes in recent commits and this part of your request is conflicting now. Can you update your code to the current master?
2. The `notifyMe` function although it's only used now by the chat it's not a chat limited function. It's supposed to be used and available for other kinds of notification as well. So either it should stay in the application or it should get a file of its own.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1564#note_86518450
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20180706/42560e81/attachment.html>


More information about the Noosfero-dev mailing list