noosfero | WIP: Rails 5.1.6 Upgrade (!1438)

Gabriel Silva gitlab at mg.gitlab.com
Tue May 29 22:00:12 BRT 2018


Gabriel Silva commented on a discussion on app/controllers/public/not_found_controller.rb:

>    end
>  
>    def nothing
> -    render :nothing => true, :status => 404
> +    head :ok, :status => 404

Yeah, but unlike the example, we also head the `status: 404`, so `head :not_found` makes more sense in here.

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1438#note_75694917
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20180530/17dc23a3/attachment-0001.html>


More information about the Noosfero-dev mailing list