noosfero | Fixing several typos (!1655)

[Gabriel Silva]

Merge request https://gitlab.com/noosfero/noosfero/merge_requests/1655 was reviewed by Gabriel Silva

--
  
Gabriel Silva started a new discussion on script/sample-enterprises:

>      end
>    end
> +  print '.'

Shouldn't this print be in the `places.each` block?

--
  
Gabriel Silva started a new discussion on script/sample-profiles:

>        end
>      end
> +  print '.'

Wrong indentation.

--
  
Gabriel Silva started a new discussion on app/models/approve_comment.rb:

>  
> -  settings_items :comment_attributes, :closing_statment
> +  settings_items :comment_attributes, :closing_statement

Same. We should not rename these fields.

--
  
Gabriel Silva started a new discussion on app/models/approve_article.rb:

>  
> -  settings_items :closing_statment, :article_parent_id, :highlighted
> +  settings_items :closing_statement, :article_parent_id, :highlighted

We shouldn't rename settings field names, this will break existing records that have some data with this key. A migration might be an option, but it's always a pain to deal with these serialized fields.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/noosfero/noosfero/merge_requests/1655
You're receiving this email because of your account on gitlab.com.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20190114/63ba6a26/attachment.html>