Making a single helper for modals in Noosfero
Antonio Terceiro
terceiro at colivre.coop.br
Fri Oct 3 18:38:24 BRT 2014
On Fri, Oct 03, 2014 at 10:05:09AM -0300, Daniel Tygel wrote:
> Hi all,
>
> We are concluding our proposal of a responsive noosfero. We've already
> finished all buttons, icons, blocks, forms, and we ended the usage of
> prototype. Now we are tackling on MODALS.
Can you send again the link of the branch in which you guys are working
on this?
> In Noosfero, we find 4 helpers for modals: colorbox, lightbox, thickbox,
> fancybox (this one to zoom images). Besides being a helper, they are also
> being called in some views and in javascript.
>
> We are proposing to unify all these helpers to a single one called
> "modal". We want also to clean all views that put directly a class to a
> modal and make them call the helper. And we want to look at the javascripts
> that call modals and make them all call this modal.
>
> The modal we are proposing is *colorbox*.
>
> Is anyone against we doing it and making a merge-request?
Not at all, this is long overdue. Having that many modal/popup
libraries, all embedded in the code is a complete mess.
> This change is needed for us to be able to have a helper calling the
> bootstrap modal.
--
Antonio Terceiro <terceiro at colivre.coop.br>
Colivre - Cooperativa de Tecnologias Livres
http://www.colivre.coop.br/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20141003/43f90428/attachment.pgp>
More information about the Noosfero-dev
mailing list