noosfero | Move vote infra from plugin to core (#589)

[Victor Franco Costa]

Thanks Daniel, I'll remember to wait a week to approve my MR in the next
time but it's clearly not the case here.
Moreover, I think that only look at the title is not enough to start a
discussion here. Sadly, this is another waste of time :(

On Wed, Jun 3, 2015 at 1:22 PM, daniel tygel <dtygel at eita.org.br> wrote:

>  Hi Victor and Leandro,
>
>    Leandro, thanks for clarifying. The MR title is misleading: it says
> that vote infra will be moved to core, which means that **something new**
> will be made to core, in terms of functionality. It would be better to
> phrase it as "Provide better vote funcionality", something like that.
>
>    Victor, I think you didn't understand what I meant: of course, making
> adjustments to something already existing is ok. But creating new
> functionalities in core must be discussed. This is absolutely not wasting
> time. It's better to be sure that something is good to everyone than having
> to refactor it later. Remember that a merge request should wait at least
> one week before being merged by the code owner if he/she is a commiter. In
> this case, the merge request was done and committed immediately, and I
> understood from the title that it was something new. If it isn't, as
> Leandro said, then ok.
>
>           daniel
>
>
> On 03-06-2015 11:15, Leandro Nunes wrote:
>
> Daniel the vote infra is already in core.
> We are not making the plugin default just fixing a mistake.
> Now other plugin could use the vote infra properly.
>
>  Thanks
>
> On Wed, Jun 3, 2015 at 11:04 AM, daniel tygel <dtygel at eita.org.br> wrote:
>
>>  Was this discussed anywhere and I lost the discussion?
>>
>> It's a core change, it should be done with more care and consensus before
>> merging, shouldn't it?
>>
>> Thanks,
>>
>> daniel
>>
>> On 02-06-2015 13:56, Leandro Nunes wrote:
>>
>>  Merge Request #589 was merged
>>
>> —
>> View it on GitLab
>> <https://gitlab.com/noosfero/noosfero/merge_requests/589> You're
>> receiving this notification because you are a member of the Noosfero /
>> noosfero project team.
>>
>>
>>  _______________________________________________
>> Noosfero-dev mailing listNoosfero-dev at listas.softwarelivre.orghttp://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>>
>>
>>
>> _______________________________________________
>> Noosfero-dev mailing list
>> Noosfero-dev at listas.softwarelivre.org
>> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>>
>>
>
>
>  --
> Dois Axé!!!
>
> -----
> "Comece fazendo o que é necessário, depois o que é possível e de repente
> você estará fazendo o impossível."
>                                    São Francisco de Assis
> Leandro Nunes
>
>
> _______________________________________________
> Noosfero-dev mailing listNoosfero-dev at listas.softwarelivre.orghttp://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>
>
>
> _______________________________________________
> Noosfero-dev mailing list
> Noosfero-dev at listas.softwarelivre.org
> http://listas.softwarelivre.org/cgi-bin/mailman/listinfo/noosfero-dev
>
>


-- 
Victor Franco Costa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listas.softwarelivre.org/pipermail/noosfero-dev/attachments/20150603/b9c8e624/attachment.html>